731807 - Error building mozilla-central on Windows 8 - 'ksguid.lib' not found

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jim Mathies [:jimm]]

It appears ksguid.lib is not distributed with the current sdk.

https://developer.mozilla.org/en/Windows_8

make[4]: Entering directory `/c/Mozilla/MC-DBG/layout/media'
c:/mozilla-build/python/python2.7.exe /c/Mozilla/mc/config/pythonpath.py -I../../config /c/Mozilla/mc/config/expandlibs_exec.py --uselist --
 link -NOLOGO -DLL -OUT:gkmedias.dll -PDB:gkmedias.pdb -SUBSYSTEM:WINDOWS -MACHINE:X86     ./module.res -LARGEADDRESSAWARE -NXCOMPAT -DYNAMI
CBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV -DEF:symbols.def   ../../gfx/ots/src/mozots.lib ../../media/libvorbis/lib/vorbis.lib ../../media/libogg
/src/ogg.lib  ../../media/libtheora/lib/theora.lib  ../../media/libnestegg/src/nestegg.lib  ../../media/libvpx/vpx.lib ../../media/libsydney
audio/src/sydneyaudio.lib  ../../media/libcubeb/src/cubeb.lib  ../../gfx/angle/angle.lib  ../../dist/lib/mozalloc.lib c:/Mozilla/MC-DBG/dist
/lib/nspr4.lib c:/Mozilla/MC-DBG/dist/lib/plc4.lib c:/Mozilla/MC-DBG/dist/lib/plds4.lib  ../../modules/zlib/src/mozz.lib winmm.lib ksguid.li
b c:/Mozilla/MC-DBG/dist/lib/mozglue.lib kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib
LINK : fatal error LNK1104: cannot open file 'ksguid.lib'
make[4]: *** [gkmedias.dll] Error 80
make[4]: Leaving directory `/c/Mozilla/MC-DBG/layout/media'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/c/Mozilla/MC-DBG/layout'
make[2]: *** [libs_tier_platform] Error 2
make[2]: Leaving directory `/c/Mozilla/MC-DBG'
make[1]: *** [tier_platform] Error 2
make[1]: Leaving directory `/c/Mozilla/MC-DBG'
make: *** [default] Error 2

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix v.1

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix v.1

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

khuey you approved the original landing so seeking r? from you. This minor touch up patch kills off a lib dependency which isn't available in the win8 dev kit.

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26dbed3d9a87

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26dbed3d9a87