732214 - [de] Port bug 731590 - Update Search Engine list for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Mark Banner (:standard8)]

The search engines list has changed in Thunderbird for en-US. See bug 731590 for the new list.

The attached patch brings de up to date with these changes. Please review and check that it will work for you.

If you have queries or issues, please feel free to ask.

If you are happy with the patch, please set the review flag to + and comment here.

When we are happy with the patch, I will commit and push to the relevant l10n repos - please let me know if you want it committed to central, aurora and/or beta. You will need to update your sign-off when you are ready.

Comment 1

[Mark Banner (:standard8)]

Attachment: Update search engines

de search engine update

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Comment on attachment 602142 [details] [diff] [review]
Update search engines

Review of attachment 602142 [details] [diff] [review]:
-----------------------------------------------------------------

Technically this patch looks good. What are the reasons to remove Google search?

Comment 3

[Mark Banner (:standard8)]

(In reply to Alexander Ihrig from comment #2)
> Technically this patch looks good. What are the reasons to remove Google
> search?

It is down to business rationale and legal decisions. We also believe that Bing will give comparable results to Google.

Comment 4

[Mark Banner (:standard8)]

Attachment: Update bing parameters

Also, as you'll see from bug 733517 we have parameters for bing now. I see you have bing-de.xml on beta, so I'd like to land this patch there.

Should bing-de.xml be on aurora as well? It seems you only have bing.xml there?

I'd like to land this early tomorrow if at all possible so that it is in the final beta.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 602142 [details] [diff] [review]
Update search engines

I've landed this on all branches:

http://hg.mozilla.org/l10n-central/de/rev/a8dab7a7a39c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/de/rev/6124920a9e57
http://hg.mozilla.org/releases/l10n/mozilla-beta/de/rev/f187b55dd9e3

It does appear there's a difference in search engines between aurora and beta, so it would be good if we could work out why that's there and fix it appropriately - I had to redo the patch for beta, but kept the essence the same.

Comment 6

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #5)
> It does appear there's a difference in search engines between aurora and
> beta, so it would be good if we could work out why that's there and fix it
> appropriately - I had to redo the patch for beta, but kept the essence the
> same.

Ok, that appears to be bug 701677 (unfortunately I wasn't following it closely enough as I don't speak German) - please remember to get my approval/ok for changes, at least so that I know they are happening and check for any issues.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 603446 [details] [diff] [review]
Update bing parameters

As we are just about to build the final beta in the next hour, I've landed this as:

http://hg.mozilla.org/releases/l10n/mozilla-beta/de/rev/0d7d6f35fca2

and will update the sign-off for it. If there are any issues, please let me know before Friday so I can take account for the final build.

Comment 8

[Mark Banner (:standard8)]

Attachment: Remove en-US copy of bing

Due to bug 701677, the de copy of bing.xml that is in central and aurora, is the same as en-US bar the newly added search parameters.

As a result we can now remove that file and the locale packaging automation will use the en-US version by default. That means there's less for us to do to keep these in sync.

This patch does that and I'll land on central and aurora if you're happy with it.

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

Mark,

in Bug 701677 Axel Hecht told me to revert to the original en-US google / bing plugins. So it's okay to 'migrate' the original en-US plugins to aurora and beta.

Regards
Alex

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 603446 [details] [diff] [review]
Update bing parameters

r+ per comment 9. This landed on beta last week.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 603670 [details] [diff] [review]
Remove en-US copy of bing

Checked in:

http://hg.mozilla.org/l10n-central/de/rev/0e91627589d8
http://hg.mozilla.org/releases/l10n/mozilla-aurora/de/rev/dc6faea16807

Comment 12

[Mark Banner (:standard8)]

Thanks Alex.