732319 - Leak when an image needs CORS and the nsCORSListenerProxy constructor fails

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I ran into this by accident when I triggered CORS on some data: images when it should not have been happening.

Minimal leaking testcase:

  <img crossorigin src="data:a/a,">

What happens here is that we get to the nsCORSListenerProxy constructor in LoadImage, that errors out and we return.  But we already have a cycle between the imgRequest and the imgCacheEntry at that point, so we lose.

Patch coming up.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix leaks on CORS failures in imagelib.

Comment 2

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/180aae8f8d2d

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/180aae8f8d2d