Closed
Bug 732379
Opened 12 years ago
Closed 12 years ago
send window is roundish and lacks border at top
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: andreasn, Assigned: Paenglab)
Details
Attachments
(3 files, 4 obsolete files)
113.49 KB,
image/png
|
Details | |
95.97 KB,
image/png
|
Details | |
8.58 KB,
patch
|
andreasn
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
On nightly the compose window currently lacks a 1px line and is somewhat rounded (3.5px or so) at the top.
Comment 1•12 years ago
|
||
We should probably make the background extend up to the top of the window so that the toolbar and menubar aren't glassy (like how the main window is now).
Assignee | ||
Comment 2•12 years ago
|
||
This patch removes the radii and gives a border. Bwinton asked for the radii. But because to add the radii in AB was not doable with the treecols on top, the compozer was the only window with radii and it makes sense to remove them.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #602580 -
Flags: ui-review?(nisses.mail)
Attachment #602580 -
Flags: review?(nisses.mail)
Assignee | ||
Comment 3•12 years ago
|
||
Andreas, what do you mean to this non-transparent window as suggested by squib? When you like it, I can do this also for the AB. This two windows are the only with this toolbars on Glass.
Attachment #602582 -
Flags: feedback?(nisses.mail)
Reporter | ||
Updated•12 years ago
|
Attachment #602580 -
Flags: ui-review?(nisses.mail) → ui-review+
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 602582 [details] [diff] [review] No transparent window Feedback+ from me
Attachment #602582 -
Flags: feedback?(nisses.mail) → feedback+
Assignee | ||
Comment 5•12 years ago
|
||
This patch removes the Aero transparency on AB and Compozer. To look better (also wished by mconley) I added a padding of 1px at top and bottom of the toolbars.
Attachment #602580 -
Attachment is obsolete: true
Attachment #602582 -
Attachment is obsolete: true
Attachment #603824 -
Flags: ui-review?(nisses.mail)
Attachment #603824 -
Flags: review?(nisses.mail)
Attachment #602580 -
Flags: review?(nisses.mail)
Assignee | ||
Comment 6•12 years ago
|
||
I forgot the toolbox's bottom border.
Attachment #603824 -
Attachment is obsolete: true
Attachment #604765 -
Flags: ui-review?(nisses.mail)
Attachment #604765 -
Flags: review?(nisses.mail)
Attachment #603824 -
Flags: ui-review?(nisses.mail)
Attachment #603824 -
Flags: review?(nisses.mail)
Reporter | ||
Comment 7•12 years ago
|
||
Compared to the main window, the toolbars are bending inwards towards the bottom and I think it would look nicer with a similar flat view. Comparision with current patch at the top and color proposal at the bottom.
Assignee | ||
Comment 8•12 years ago
|
||
Made the gradients the same as on main window.
Attachment #604765 -
Attachment is obsolete: true
Attachment #607672 -
Flags: ui-review?(nisses.mail)
Attachment #607672 -
Flags: review?(nisses.mail)
Attachment #604765 -
Flags: ui-review?(nisses.mail)
Attachment #604765 -
Flags: review?(nisses.mail)
Reporter | ||
Comment 9•12 years ago
|
||
Comment on attachment 607672 [details] [diff] [review] No transparent window for AB and Compozer v3 UI look good! Will review the css shortly.
Attachment #607672 -
Flags: ui-review?(nisses.mail) → ui-review+
Reporter | ||
Comment 10•12 years ago
|
||
Comment on attachment 607672 [details] [diff] [review] No transparent window for AB and Compozer v3 css looks good as far as I can see.
Attachment #607672 -
Flags: review?(nisses.mail) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 11•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/1ea6513ec1b2
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•