Closed Bug 732379 Opened 12 years ago Closed 12 years ago

send window is roundish and lacks border at top

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 14.0

People

(Reporter: andreasn, Assigned: Paenglab)

Details

Attachments

(3 files, 4 obsolete files)

before and after
113.49 KB, image/png
Details
toolbar comparisions
95.97 KB, image/png
Details
No transparent window for AB and Compozer v3
8.58 KB, patch
andreasn
: review+
andreasn
: ui-review+
Details | Diff | Splinter Review
Attached image before and after — 
On nightly the compose window currently lacks a 1px line and is somewhat rounded (3.5px or so) at the top.
We should probably make the background extend up to the top of the window so that the toolbar and menubar aren't glassy (like how the main window is now).
Attached patch Fix (obsolete) — — Splinter Review 
This patch removes the radii and gives a border.

Bwinton asked for the radii. But because to add the radii in AB was not doable with the treecols on top, the compozer was the only window with radii and it makes sense to remove them.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #602580 - Flags: ui-review?(nisses.mail)
Attachment #602580 - Flags: review?(nisses.mail)
Attached patch No transparent window (obsolete) — — Splinter Review 
Andreas, what do you mean to this non-transparent window as suggested by squib?

When you like it, I can do this also for the AB. This two windows are the only with this toolbars on Glass.
Attachment #602582 - Flags: feedback?(nisses.mail)
Attachment #602580 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 602582 [details] [diff] [review]
No transparent window

Feedback+ from me
Attachment #602582 - Flags: feedback?(nisses.mail) → feedback+
This patch removes the Aero transparency on AB and Compozer. To look better (also wished by mconley) I added a padding of 1px at top and bottom of the toolbars.
Attachment #602580 - Attachment is obsolete: true
Attachment #602582 - Attachment is obsolete: true
Attachment #603824 - Flags: ui-review?(nisses.mail)
Attachment #603824 - Flags: review?(nisses.mail)
Attachment #602580 - Flags: review?(nisses.mail)
I forgot the toolbox's bottom border.
Attachment #603824 - Attachment is obsolete: true
Attachment #604765 - Flags: ui-review?(nisses.mail)
Attachment #604765 - Flags: review?(nisses.mail)
Attachment #603824 - Flags: ui-review?(nisses.mail)
Attachment #603824 - Flags: review?(nisses.mail)
Attached image toolbar comparisions — 
Compared to the main window, the toolbars are bending inwards towards the bottom and I think it would look nicer with a similar flat view. Comparision with current patch at the top and color proposal at the bottom.
Made the gradients the same as on main window.
Attachment #604765 - Attachment is obsolete: true
Attachment #607672 - Flags: ui-review?(nisses.mail)
Attachment #607672 - Flags: review?(nisses.mail)
Attachment #604765 - Flags: ui-review?(nisses.mail)
Attachment #604765 - Flags: review?(nisses.mail)
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

UI look good! Will review the css shortly.
Attachment #607672 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 607672 [details] [diff] [review]
No transparent window for AB and Compozer v3

css looks good as far as I can see.
Attachment #607672 - Flags: review?(nisses.mail) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/1ea6513ec1b2
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 14.0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: