732800 - Fix include paths in <script type="application/javascript" src="amUtils.js"/> to 'chrome://messenger/content/amUtils.js'

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[:aceman]

There are several occurrences of this style in the /mailnews/ tree.

Comment 1

[:aceman]

Attachment: fix

I am not sure about the gloda path.

Comment 2

[Jonathan Protzenko [:protz]]

Comment on attachment 602726 [details] [diff] [review]
fix

That looks like a valid path (for Thunderbird). Out of curiosity, why the cleanup? Did someone rule that it was bad practice to use relative paths in overlays now?

Comment 3

[:aceman]

No, I just thought to clean it up because the prevailing style was to use absolute paths. I do not know if it is bad or good. Let's see what Ian and Mark say.

Comment 4

[Ian Neal]

Comment on attachment 602726 [details] [diff] [review]
fix

>+++ b/mailnews/base/prefs/content/SmtpServerEdit.xul
>+<script type="application/javascript" src="chrome://messenger/content/amUtils.js"/>
>+<script type="application/javascript" src="chrome://messenger/content/SmtpServerEdit.js"/>
Nit: as over 80 characters have src on separate line for each of the above.

>+++ b/mailnews/base/prefs/content/am-identities-list.xul
>+<script type="application/javascript" src="chrome://messenger/content/am-identities-list.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-identity-edit.xul
>+  <script type="application/javascript" src="chrome://messenger/content/am-identity-edit.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-server-advanced.xul
>+  <script type="application/javascript" src="chrome://messenger/content/am-server-advanced.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/base/prefs/content/am-smtp.xul
>+  <script type="application/javascript" src="chrome://messenger/content/amUtils.js"/>
>+  <script type="application/javascript" src="chrome://messenger/content/am-smtp.js"/>
Nit: as over 80 characters have src on separate line for each of the above.

>+++ b/mailnews/base/prefs/content/smtpEditOverlay.xul
>+  <script type="application/javascript" src="chrome://messenger/content/smtpEditOverlay.js"/>
Nit: as over 80 characters have src on separate line.

>+++ b/mailnews/db/gloda/content/thunderbirdOverlay.xul
>+  <script src="chrome://gloda/content/overlay.js"/>
Nit: you add type here too and as it will be over 80 characters have src on separate line.

r=me with those fixed

Comment 5

[:aceman]

Attachment: fix v2

Thanks, done.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/9890feabdc74