7330 - [Necko] nsIWebShellServices::StopLoadingDocument is not reentr safe

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Frank Tang]

The StopLoadingDocuemnt of nsWebShell is not safe to be called from the
nsMetaCharsetObserver. It crash on Mac and Linux when the first block of data
contained the full META charset tag.

I temp fix this by comment out the call to StopLoadingDocument in the
intl/chardet/src/nsMetaCharsetObserber.cpp . if you uncomment out that two line
you can easily reproduce problem on Linux and Mac. Not easy to see the problem
on window.
Related bug 7239, 7241, 7242, 3921, 7240

Comment 1

[Nisheeth Ranjan]

This bug is happening because on Mac and Unix, netlib callbacks can happen
before the load url call stack unwinds.  This will get fixed by the Necko
landing because all three platforms will start using the same threading
architecture.  Right now, on Mac and Unix, netlib and layout run on a single
thread while on Windows, they are on separate threads.

Rick, please correct me if I am goofing up here.  Thanks.

Setting target milestone to M8 and accepting bug.

Comment 2

[Nisheeth Ranjan]

*** Bug 7208 has been marked as a duplicate of this bug. ***

Comment 3

[Nisheeth Ranjan]

Moving out Necko related bugs to M9...

Comment 4

[Nisheeth Ranjan]

Moving bugs blocked by Necko to M10...

Comment 5

[Nisheeth Ranjan]

Now that Necko has landed, this bug should be fixed.  Frank, I'm assigning this
to you so that you can see what happens on Mac and Unix when you re-enable your
code.  Please pass it back to me if you run into problems.  Thanks.

Comment 6

[Frank Tang]

check in the remove of the work around. Mark this fixed

Comment 7

[Hixie (not reading bugmail)]

Moving all threading bugs to XPCOM. See bug 160356.