733003 - "failed to cleanup" message should be more helpful

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

http://hg.mozilla.org/build/talos/file/6694f881a3fb/talos/ffprocess.py#l91

This isn't very helpful for diagnosis.  We should output more about
the process information for diagnosis

Comment 1

[Jeff Hammel]

Attachment: print out running processes

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 602937 [details] [diff] [review]
print out running processes

Review of attachment 602937 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/ffprocess.py
@@ +88,5 @@
>              # and we need to give it a little extra time to complete
>              time.sleep(browser_wait)
> +            processes = self.checkAllProcesses(process_name, child_process):
> +            if processes:
> +                raise talosError("failed to cleanup processes: %s" % processes)

I would like to make this more robust:
msg = "Failed to cleanup, no processes found"
if processes:
    msg = "Failed to cleanup processes: %s" % processes
raise talosError(msg)

Comment 3

[Jeff Hammel]

If no processes are found, then cleanup is successful, and we don't raise a talosError

Comment 4

[Jeff Hammel]

beh, forgot to remove a ':'

Comment 5

[Jeff Hammel]

Attachment: oops

Comment 6

[Jeff Hammel]

tested locally on android ts + tsvg

Comment 7

[Jeff Hammel]

try push: https://tbpl.mozilla.org/?tree=Try&rev=b997c2d57863

Comment 8

[Mozilla RelEng Bot]

Try run for 6dbeb77e5f31 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=6dbeb77e5f31
Results (out of 39 total builds):
    exception: 19
    success: 5
    failure: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-6dbeb77e5f31

Comment 9

[Jeff Hammel]

try looks pretty green, pushing: http://hg.mozilla.org/build/talos/rev/6694f881a3fb

Comment 10

[Mozilla RelEng Bot]

Try run for b997c2d57863 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b997c2d57863
Results (out of 73 total builds):
    success: 70
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b997c2d57863
 Timed out after 06 hours without completing.