733327 - javascript: URLs are listed in AwesomeBar

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: Screenshot 1

Firefox 13.0a1 (2012-03-05)
Device: HTC Desire
OS: Android 2.2

Steps to reproduce:
1. Open Fennec
2. Browse to javascript:('lol')
3. Tap on URL Bar
4. Verify if javascript:('lol') is listed in Top Sites and History tabs

Expected result:
javascript:('lol') is not listed in AwesomeBar

Actual result:
I loaded in a new tab javascript:('lol') and the string was displayed in the new opened page. I closed the tab and about:home (which was default loaded) was on the screen. I tapped on URL Bar for Awesomesbar and the javascript:('lol') was listed there (see screenshot 1), but if I tap on it, Fennec will just switch to about:home.

Also the thumbnail of javascript: page is listed on about:home (see screenshot 2), but if I tap on it, the throbber starts spinning without opening that javascript: page. And it seems that will stay like that forever.

Comment 1

[Cristian Nicolae (:xti)]

Attachment: Screenshot 2

Comment 2

[Tony Chung [:tchung]]

reproduced on 3-20-2012 nightly build.   the javascript page appears in my history selection after loading page.

Flagging for nom.

Comment 3

[:Margaret Leibovic]

In bug 725609, we decided that users should be able to use bookmarklets synced over from desktop, and in order to access those, we'd need to still show javascript: URLs at least in the bookmarks UI.

I think the real problem here is that javascript: URLs entered in the URL bar shouldn't be stored in history, since they won't be executed anyway. Maybe our error handling code around that needs to be better. Tapping a javascript: URL certainly shouldn't change your location (unless that's part of the js in a bookmarklet I suppose), and we don't want the throbber to end up in a perma-on state.

Comment 4

[Brian Nicholson (:bnicholson)]

I don't see this anymore using the STR in comment 0.