Closed Bug 733513 Opened 12 years ago Closed 12 years ago

Enable accessibility on Mac

Categories

(Core :: Disability Access APIs, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: hub, Assigned: hub)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

For Firefox 14 (tentatively), enable accessibility on Mac.
Assignee: nobody → hub
Depends on: 718627
Attached patch Enable Accessibility on Mac. r= (obsolete) — Splinter Review
Attachment #603427 - Attachment is obsolete: true
Depends on: 716935
Depends on: 740696
Attachment #603536 - Attachment is obsolete: true
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=

We want to make sure enabling a11y in Nightly for Mac has a negligible impact. We are prepared to back it out before the next Aurora uplift if needed.
Attachment #618373 - Flags: review?(ted.mielczarek)
Depends on: 746160
No longer depends on: 716935
Comment on attachment 618373 [details] [diff] [review]
Enable accessibility by default on Mac. r=

Review of attachment 618373 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -4604,5 @@
> -
> -case "${target}" in
> -*darwin*)
> -    ACCESSIBILITY=
> -    MOZ_WEBAPP_RUNTIME=1

You seem to be losing this MOZ_WEBAPP_RUNTIME here.
Attachment #618373 - Flags: review?(ted.mielczarek) → review-
damn. I messed up the rebase.

good catch.
Attachment #618373 - Attachment is obsolete: true
Attachment #618463 - Attachment is obsolete: true
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.

Fixed that mistake in the previous version.
Attachment #618473 - Flags: review?(ted.mielczarek)
Comment on attachment 618473 [details] [diff] [review]
Enable accessibility by default on Mac.

Does this enable the mochitests-a11y on all Mac builds automatically, too, or do these need to be turned on separately?
I don't enable any test.
Attachment #618473 - Flags: review?(ted.mielczarek) → review+
You'll need a separate bug in mozilla.org : Release Engineering to enable mochitest-a11y on mac builds.
Blocks: 749160
Rebased and pushed to inbound on Hub's behalf: http://hg.mozilla.org/integration/mozilla-inbound/rev/76447b588eea
Note that this only enables accessibility, it does not yet run the Mochitest suite of tests. This will be dealt with in bug 749160 separately.
Target Milestone: --- → mozilla15
http://hg.mozilla.org/mozilla-central/rev/76447b588eea
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
backed out with bug 761256. Will come back with bug 761763
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: