733612 - Add a pseudo-class lock menu to the infobar node menu

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Heather Arthur [:harth]]

We need to add the pseudo-class lock menuitems to the infobar node menu from bug 717916. They are currently in a context menu, added in bug 707740.

Comment 1

[Heather Arthur [:harth]]

Attachment: Add pseudo-class lock menu to node menu and remove from context menu

This patch adds the pseudo-class lock menu items to the infobar's node menu. It also removes them from the infobar's context menu.

Comment 2

[Heather Arthur [:harth]]

Attachment: Add pseudo-class lock menu to node menu and remove from context menu

Sorry, here's the real patch.

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 603975 [details] [diff] [review]
Add pseudo-class lock menu to node menu and remove from context menu

Review of attachment 603975 [details] [diff] [review]:
-----------------------------------------------------------------

r=+ with the new className.

::: browser/devtools/highlighter/highlighter.jsm
@@ +500,5 @@
> +    let separator = this.chromeDoc.createElement("menuseparator");
> +    menu.appendChild(separator);
> +
> +    menu.addEventListener("popupshowing", function() {
> +      let items = menu.getElementsByClassName("pseudo-class-menuitem");

I usually prefer menu.querySelectorAll(".pseudo-class-menuitem")
(Up to you)

@@ +557,4 @@
>        let item = this.chromeDoc.createElement("menuitem");
>        item.setAttribute("type", "checkbox");
>        item.setAttribute("label", pseudo);
> +      item.className = "pseudo-class-menuitem";

Can you prefix the class with: "highlighter-"?
Like: highlighter-pseudo-class-menuitem

Comment 4

[Paul Rouget [:paul]]

triage, filter on centaur

Comment 5

[Paul Rouget [:paul]]

I realise we don't have any test for that. Can we get one before landing this?

Comment 6

[Paul Rouget [:paul]]

@harth, can you do it, or do you want me to do it?

Comment 7

[Heather Arthur [:harth]]

Attachment: patch unbitrotted plus test

New patch, updated and with a test.

Comment 8

[Heather Arthur [:harth]]

Attachment: new patch plus moving infobar

As discussed on irc, we want to reposition the infobar when the pseudo-class is added to the selector. This new patch includes this.

Comment 9

[Heather Arthur [:harth]]

http://hg.mozilla.org/integration/fx-team/rev/0ba7e290a08f

Comment 10

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/0ba7e290a08f