Closed
Bug 733773
Opened 12 years ago
Closed 12 years ago
Building with a value for --with-arch different from our default for MOZ_ARCH should reset our defaults for MOZ_THUMB and others
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla14
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
26.81 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
At the same time, this forces the flags used when compiling nspr (which, until we'd land a 4.9.1 beta, builds as armv5) independently of what nspr does by default, and adds the thumb default for iOS to the main configure.in (it was only added to js/src/configure.in). This also moves configure.in and js/src/configure.in parts in a semi-common (as in, forced to be synchronized) file.
Attachment #604012 -
Flags: review?(ted.mielczarek)
Comment 2•12 years ago
|
||
Comment on attachment 604012 [details] [diff] [review] Reset default values for thumb, float-abi, etc. when --with-arch is specified Review of attachment 604012 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/arch.m4 @@ +44,5 @@ > + ;; > + esac > +fi > + > +dnl Kept for compatibility with some buildbot mozconfig We should probably just fix the mozconfigs at this point, since they're in-tree. (If this comment even still applies.) ::: configure.in @@ +1542,5 @@ > x86_64|i?86) > INTEL_ARCHITECTURE=1 > esac > > +MOZ_ARCH_OPTS Can we get a comment here with a brief summary of what this does? Even just "configure platform-specific CPU architecture compiler options" or something like that.
Attachment #604012 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #2) > Comment on attachment 604012 [details] [diff] [review] > Reset default values for thumb, float-abi, etc. when --with-arch is specified > > Review of attachment 604012 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: build/autoconf/arch.m4 > @@ +44,5 @@ > > + ;; > > + esac > > +fi > > + > > +dnl Kept for compatibility with some buildbot mozconfig > > We should probably just fix the mozconfigs at this point, since they're > in-tree. (If this comment even still applies.) I'll just remove that when landing: the only mozconfigs that were using this are the android-nothumb ones, and they are gone.
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03394bda1d0f
Assignee | ||
Comment 5•12 years ago
|
||
Backed out, because it turns Windows red: https://hg.mozilla.org/integration/mozilla-inbound/rev/d932f160f91c
Assignee | ||
Comment 6•12 years ago
|
||
This solves the windows problem.
Attachment #605360 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•12 years ago
|
Attachment #604012 -
Attachment is obsolete: true
Updated•12 years ago
|
Attachment #605360 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/409679237c31
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/409679237c31
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•