734045 - GCLI resource doesn't always find script tags

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Joe Walker [:jwalker]]

>>> document.body.querySelectorAll("script");
undefined

>>> document.body.getElementsByTagName("script");
undefined

>>> document.body.children[5];
<script src="scripts/require.js" type="text/javascript">

Comment 1

[Joe Walker [:jwalker]]

GCLI Triage.

Comment 2

[Joe Walker [:jwalker]]

Attachment: Upload 1

Turns out this was a test failure.
This is trivial enough that I'm not going to bother with a pull request.

But for your delectation, the commit message:

    Bug 734045 (script0): Use getLookup not getPredictions
    
    The results of getPredictions are filtered through the matcher which
    prevents the return of more than 10 results, so it's silly doing maths on
    the lengths expecting it to work. Instead we should be using getLookup
    directly which isn't filtered, and so the length maths will work.

Comment 3

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=c9b7a566ff05

Comment 4

[Joe Walker [:jwalker]]

(Also fwiw: https://tbpl.mozilla.org/?tree=Try&rev=3e09d6ee6d89)

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/mozilla-central/rev/c9b7a566ff05