734075 - Closing FF in Private mode close also the bookmarks panel

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build ID: 20120215223356

Steps to reproduce:

1. Start Firefox.
2. Open Bookmarks panel.
3. Run Private mode.
4. Close Firefox (with Private mode activated).
5. Run Firefox again and...the Bookmarks panel is closed (as in the Private mode is).


Actual results:

If you switch to Normal mode before closing FF, the Bookmarks panel appears again and after the restart it stays opened.


Expected results:

IMHO Firefox should hide the Bookmarks panel when it's in Private mode, but after restart the panel should be reopened.

Comment 1

[(no longer active)]

Why should we hide the bookmarks panel?

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

The hiding feature is not important. The main reason why I fill this bug, is to open it after restart, if it had been opened before switching to private mode.

Comment 3

[(no longer active)]

So I just did the following:

1. Started Firefox.
2. Opened the bookmarks sidebar.
3. Switched into private browsing mode.
4. Quit Firefox.
5. Started it again.

The bookmark sidebar is opened at step 5.  Is there something I'm missing here?

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

In my case the sidebar stays closed.
I have created also a new virtual WinXP computer with clear FF installation, but it doesn't work there either.

Can someone else check it and confirm, what behavior is normal?

Comment 5

[(no longer active)]

Weird, I can't reproduce myself...

Comment 6

[Marcia Knous [:marcia]]

Using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0, I haven't be able to reproduce this either. Will try on a different machine.

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

(In reply to Marcia Knous [:marcia] from comment #6)
> Using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101
> Firefox/12.0, I haven't be able to reproduce this either. Will try on a
> different machine.

I am not able to test it on Mac - maybe it's occurs at Windows only.

Comment 8

[(no longer active)]

Paul, are you aware whether the sessionrestore component is the one handling the bookmarks side bar?

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Ehsan Akhgari [:ehsan] from comment #8)
> Paul, are you aware whether the sessionrestore component is the one handling
> the bookmarks side bar?

I think that's persisted via localstore.rdf.

I think the issue is the difference between quitting & closing the last window to quit. I can reproduce on Linux when closing the last window to quit. But if I quit through File > Exit, then things work as expected.

Comment 10

[(no longer active)]

Do you know what component is responsible for localstore.rdf?

Comment 11

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Core > XUL I think

nsXULDocument::Persist is where it ultimately happens, but there may be another layer on top controlling when that gets called.

Comment 13

[u279076]

What's need from QA on this bug, if anything?

Comment 14

[(no longer active)]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #13)
> What's need from QA on this bug, if anything?

Nothing, forgot to clear the flag.

Comment 15

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

As Firefox now opens entire private windows, this bug is no more reproducible.