734083 - Add balrog database admin form base class

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Erick Dransch [:edransch]]

All forms which allow database queries will need the data_version field.

We should have a Base Class for all such forms which contains only that field. It can then be extended for any desired functionality.

Comment 1

[Erick Dransch [:edransch]]

Attachment: base class for form that edit database

Add new class which contains the hidden data-version field used for database edits.
All forms which allow database modifications should inherit from this.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 604130 [details] [diff] [review]
base class for form that edit database

Review of attachment 604130 [details] [diff] [review]:
-----------------------------------------------------------------

::: auslib/web/views/forms.py
@@ +35,5 @@
>          else:
>              log.debug('JSONTextField: No value list, setting self.data to {}')
>              self.data = {}
>  
> +class DbEditForm(Form):

Minor name quibble: EditableForm. Can you change that on your github branch? No need to repost.

Comment 3

[Erick Dransch [:edransch]]

Attachment: base class for form that edits database

Updated to address feedback

Comment 4

[Erick Dransch [:edransch]]

Attachment: Add base class for DB edit forms

The patch that was attached was invalid. This one should apply cleanly.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 608829 [details] [diff] [review]
Add base class for DB edit forms

Review of attachment 608829 [details] [diff] [review]:
-----------------------------------------------------------------

Landed this, Jenkins run is here: https://jenkins.mozilla.org/job/Balrog/57/