734280 - [New Tab Page] clean up newtab test suite

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Here's what I did:

1) I removed the callback parameters from Site.block(), Site.unpin() and Drop.drop() because they were only used for testing purposes. Now that we have whenPagesUpdated() we can remove this entirely.

2) The global variables 'cells' and 'cw' are no longer and we now have some convenience functions to replace them.

3) I refactored checkGrid() because that was a hell of a function and can be written much smaller and easier.

4) I added sendDragEvent() and createDragEvent() to head.js to not violate the DRY principle - two tests had custom implementations of these functions.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

It's all green, whee! https://tbpl.mozilla.org/?tree=Try&rev=2e3c04e73f3f

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 608655 [details] [diff] [review]
patch v1

Review of attachment 608655 [details] [diff] [review]:
-----------------------------------------------------------------

yay globals--, r=me

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/5b1154a3289c

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5b1154a3289c