734294 - when installing an app the InstallTime is returning undefined

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[[e-mail] [:onecyrenus]]

navigator.mozApps.install in onSuccess

installTime = undefined

This is on mozilla-central.

Comment 1

[[e-mail] [:onecyrenus]]

The difference I was seeing with the HTML / JS implementation here is that installTime in the onSuccess handler whereas in ff it is not. 

It seems more natural for this to be returned later in getInstalled, which is the way ff does it .

Comment 2

[Ian Bicking (:ianbicking)]

Attachment: Fix for bug, plus test

One-line fix, plus MochiTest

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 632103 [details] [diff] [review]
Fix for bug, plus test

Review of attachment 632103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/apps/src/Webapps.jsm
@@ +181,4 @@
>      }
>  
>      let appObject = this._cloneAppObject(app);
> +    appObject.installTime = app.installTime = (new Date()).getTime();

Nit: Date.now() is fine also

Comment 4

[Ian Bicking (:ianbicking)]

Attachment: Fix with nit addressed

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 634085 [details] [diff] [review]
Fix with nit addressed

https://hg.mozilla.org/integration/mozilla-inbound/rev/92aa87e1e876

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/92aa87e1e876