734306 - nsNPAPIPluginInstance.cpp:1491:10: warning: implicit conversion from 'nsresult' (aka 'unsigned int') to 'NPError' (aka 'short') changes value from 2147500037 to 16389 (also line 1500)

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jeff Walden [:Waldo]]

NPError
nsNPAPIPluginInstance::InitAsyncSurface(NPSize *size, NPImageFormat format,
                                        void *initData, NPAsyncSurface *surface)
{
  if (mOwner)
    return mOwner->InitAsyncSurface(size, format, initData, surface);

  return NS_ERROR_FAILURE;
}

NPError
nsNPAPIPluginInstance::FinalizeAsyncSurface(NPAsyncSurface *surface)
{
  if (mOwner)
    return mOwner->FinalizeAsyncSurface(surface);

  return NS_ERROR_FAILURE;
}

We're defining a method that returns NPError, then returning an nsresult from it.  Clearly a bug, no idea what the consequences are.  (And <3 clang for pointing it out so nicely, including with the truncated value parts.)

Comment 1

[Josh Aas]

I think this probably landed with Bas's async NPAPI implementation.

Comment 2

[Josh Aas]

Attachment: fix v1.0

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 604454 [details] [diff] [review]
fix v1.0

Review of attachment 604454 [details] [diff] [review]:
-----------------------------------------------------------------

I doubt there's significant consequences! But this is a good change!

Comment 4

[Josh Aas]

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/de4b5d7ba0e5

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/de4b5d7ba0e5