734331 - Convert shell integration into a JavaScript component

Status: NEW

(Firefox :: Shell Integration, defect)

Description

[Robert Strong (they/them - no direct email)]

I'd like to convert the current shell integration c++ into JavaScript (windows only for this bug) and thereby get rid of the only dll we have under components.

Do any of you that I have cc'd (especially Gavin) have a problem with this?

Comment 1

[Brian R. Bondy [:bbondy]]

I have no major problem with it, but what is the primary motivation for this change? Or why is not having any DLLs under components desirable enough to warrant development time over other areas?

Comment 2

[Robert Strong (they/them - no direct email)]

Firefox would no longer need to open and parse binary.manifest and load the browsercomps.dll during startup.

I don't see this as a high priority and shouldn't take time from other higher priority development though I suspect not parsing binary.manifest and not loading browsercomps.dll would help startup in a similar manner as other recent projects have done. Also, the majority of the work is fairly simple to implement so it shouldn't take all that long.

Comment 3

[Brian R. Bondy [:bbondy]]

> not parsing binary.manifest and not loading browsercomps.dll would help startup

Awesome, thanks for the extra info.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sounds great. Presumably this is going to involve exposing additional C++ APIs via XPCOM?