Closed
Bug 734333
Opened 12 years ago
Closed 12 years ago
typo in RIL.iccIO() throws ReferenceError: request is not defined
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: vicamo, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
2.74 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
I/Gecko ( 2621): RIL Worker: Parcel handling threw ReferenceError: request is not defined I/Gecko ( 2621): iccIO([object Object])@resource://gre/modules/ril_worker.js:944 I/Gecko ( 2621): getMSISDN()@resource://gre/modules/ril_worker.js:2244 I/Gecko ( 2621): onRadioStateChanged(4)@resource://gre/modules/ril_worker.js:1525 I/Gecko ( 2621): UNSOLICITED_RESPONSE_RADIO_STATE_CHANGED(4,(void 0))@resource://gre/modules/ril_worker.js:1295 I/Gecko ( 2621): handleParcel(1000,4,(void 0))@resource://gre/modules/ril_worker.js:999 I/Gecko ( 2621): processParcel()@resource://gre/modules/ril_worker.js:490 I/Gecko ( 2621): processIncoming([object Uint8Array])@resource://gre/modules/ril_worker.js:433 I/Gecko ( 2621): onRILMessage([object Uint8Array])@resource://gre/modules/ril_worker.js:3216 and change https://hg.mozilla.org/mozilla-central/rev/36c4724de5bf, patch chunk 2, line 41: 2.41 + if (request.pin2 != null) { 2.42 + Buf.writeString(pin2); 2.43 + } `request` should be `options`.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → yhuang
Comment 2•12 years ago
|
||
Comment on attachment 604321 [details] [diff] [review] patch Review of attachment 604321 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for introducing the typo and many thanks for fixing it, Yoshi!
Attachment #604321 -
Flags: review?(philipp) → review+
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/170757be69f3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Assignee | ||
Comment 4•12 years ago
|
||
No worries, it should be my fault that didn't notice this in the first place, thank you and also thanks Vicamo discovered this. :)
You need to log in
before you can comment on or make changes to this bug.
Description
•