734351 - Syntax error in the migration query in MigrateV17up

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

This is quite bad, but if I'm not wrong only affects a small percentage of users who may have started using Nightly in the last 2 weeks or so.
Btw, should absolutely be fixed before the merge.

[12:18]	Ms2ger	WARNING: The SQL statement 'INSERT OR IGNORE INTO moz_hosts (host, frecency) SELECT fixup_url(get_unreversed_host(h.rev_host)) AS host, (SELECT MAX(frecency) FROM moz_places WHERE rev_host = get_unreversed_host(host || '.') || '.' OR rev_host = get_unreversed_host(host || '.') || '.www.') ) AS frecency FROM moz_places h WHERE LENGTH(h.rev_host) > 1 GROUP BY h.rev_host' could not be compiled due to an error: near ")": syntax error:
[12:18]	Ms2ger	file /storage/src/mozStorageConnection.cpp, line 956

Comment 1

[Marco Bonardo [:mak]]

To confirm, this hits users who migrated from a previous version to Nightly from 2012-02-23 to today, so it's quite limited, though we should not release the bug in Aurora, for sure.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d149aecd50

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c3d149aecd50