734517 - GC: missing barriers in InitExnPrivates

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

InitExnPrivate needs to trigger barriers when copying out to the heap, but not when copying data into the on-stack vector.

Comment 1

[Terrence Cole [:terrence]]

Attachment: v0

I verified that this patch fixes half the failures I am experiencing with my write buffer.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 605095 [details] [diff] [review]
v0

Review of attachment 605095 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsexn.cpp
@@ +122,5 @@
> +typedef JSStackTraceElemImpl<HeapPtrString> JSStackTraceElem;
> +typedef JSStackTraceElemImpl<JSString *>    JSStackTraceStackElem;
> +
> +static void
> +copyTraceElemToHeap(JSStackTraceElem *dst, JSStackTraceStackElem *src)

Can you just put the code directly in the loop? If it's in a function, it's possible people will call it without realizing that it does init() rather than set().

Also, in general, functions like this should start with an uppercase letter.

Comment 3

[Terrence Cole [:terrence]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/da22cf5a850f

Comment 4

[Terrence Cole [:terrence]]

Thanks for the help, bugzilla, but no.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/da22cf5a850f