Closed Bug 734536 Opened 12 years ago Closed 3 years ago

Crash when sending Prompt:Show to java with invalid JSON

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
critical

Tracking

(blocking-fennec1.0 -)

RESOLVED INCOMPLETE
Tracking Status
blocking-fennec1.0 --- -

People

(Reporter: wesj, Unassigned)

Details

(Keywords: crash, Whiteboard: [native-crash])

Writing an extension last weekend, I noticed that I can crash Fennec by sending invalid stuff to Prompt:Show. For instance, if I send:

type: "Prompt:Show", buttons: [ "OK", "Cancel" ]

will crash because buttons should be:

type: "Prompt:Show", buttons: [ {label:"OK"}, {label:"Cancel"} ]

I think I am catching the JSON error, but still attempting to open the dialog, which is leading to NPE's. We should bail if there are any errors in the JSON.
Severity: normal → critical
Keywords: crash
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → -
Whiteboard: [native-crash]
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.