734757 - Platform::GetOffscreenFormat called from non-main thread, and breaking Qt port

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

ASSERT failure in QWidget: "Widgets must be created in the GUI thread.", file kernel/qwidget.cpp, line 1298

#0  TouchBadMemory () at memory/mozalloc/mozalloc_abort.cpp:68
#1  0x40091c72 in mozalloc_abort (msg=<optimized out>) at memory/mozalloc/mozalloc_abort.cpp:89
#2  0x40091c94 in abort () at memory/mozalloc/mozalloc_abort.cpp:110
#3  0x427f71d8 in qt_message_output (msgType=<optimized out>, buf=<optimized out>) at global/qglobal.cpp:2252
#4  0x427f732c in qt_message (msgType=QtFatalMsg, msg=<optimized out>, ap=<optimized out>) at global/qglobal.cpp:2298
#5  0x427f73c8 in qFatal (msg=0x429a5b1c "ASSERT failure in %s: \"%s\", file %s, line %d") at global/qglobal.cpp:2481
#6  0x427f7408 in qt_assert_x (where=0x425fd76c "QWidget", what=<optimized out>, file=<optimized out>, line=<optimized out>) at global/qglobal.cpp:2007
#7  0x41f0200c in QWidgetPrivate::init (this=0x4880aa30, parentWidget=0x0, f=...) at kernel/qwidget.cpp:1297
#8  0x41f0239c in QWidget::QWidget (this=0x48811a88, parent=0x0, f=...) at kernel/qwidget.cpp:1172
#9  0x41f29f04 in QDesktopWidget::QDesktopWidget (this=0x48811a88) at kernel/qdesktopwidget_qws.cpp:51
#10 0x41ea3048 in QApplication::desktop () at kernel/qapplication.cpp:3265
#11 0x40ea3b70 in gfxQtPlatform::GetOffscreenFormat (this=<optimized out>) at gfx/thebes/gfxQtPlatform.cpp:643
#12 0x40eaadce in CreateImage (aRecycleBin=0x1beeee0, aScaleHint=..., aNumFormats=<optimized out>, aFormats=<optimized out>, this=<optimized out>)
    at gfx/layers/basic/BasicImages.cpp:103
#13 mozilla::layers::BasicImageFactory::CreateImage (this=<optimized out>, aFormats=<optimized out>, aNumFormats=1, aScaleHint=..., aRecycleBin=0x1beeee0)
    at gfx/layers/basic/BasicImages.cpp:92
#14 0x40ec18d6 in mozilla::layers::ImageContainer::CreateImage (this=0x15e4458, aFormats=0x4330f9d4, aNumFormats=1) at gfx/layers/ImageLayers.cpp:115
#15 0x409bd8c0 in VideoData::Create (aInfo=..., aContainer=0x15e4458, aOffset=340199, aTime=4291666, aEndTime=4333333, aBuffer=..., aKeyframe=false, aTimecode=4325, aPicture=...)
    at content/media/nsBuiltinDecoderReader.cpp:165
#16 0x409c5cfe in nsOggReader::DecodeTheora (this=0x1bf2ad0, aPacket=<optimized out>, aTimeThreshold=<optimized out>) at content/media/ogg/nsOggReader.cpp:476
#17 0x409c5e8a in nsOggReader::DecodeVideoFrame (this=0x1bf2ad0, aKeyframeSkip=<optimized out>, aTimeThreshold=3833636) at content/media/ogg/nsOggReader.cpp:521

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Cache offscreen format type in main thread

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Cache offscreen format type in main thread

Ups, fixed minor pointer typo

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ff628801bd90

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ff628801bd90