735196 - Support "bugs.php.net" URLs in "See also" field

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Description

[Thomas D. (:thomas8)]

Attachment: Patch by Marcin CIESLAK to support "bugs.php.net" URLs in "See also" field

+++ This bug was initially created as a clone of Bug #543667 +++

From bug 577847, comment 12, there's a patch from Marcin CIESLAK to support "bugs.php.net" URLs in "See also" field. I've moved that patch here so that it can be reviewed in its own bug.

Comment 1

[Frédéric Buclin]

Comment on attachment 605346 [details] [diff] [review]
Patch by Marcin CIESLAK to support "bugs.php.net" URLs in "See also" field

This is old code. The See Also code has been moved into BugUrl/*. Also, I don't think we need to support php.net in our core code. It should go into the MoreBugUrl extension.

Comment 2

[Thomas D. (:thomas8)]

Frédéric, could you provide an mxr link to the MoreBugURL extension, so that Marcin might provide a new patch?

Comment 3

[:glob ✱]

it's an extension which is bundled with bugzilla:

http://bzr.mozilla.org/bugzilla/trunk/files/head:/extensions/MoreBugUrl/

Comment 4

[Marcin Cieślak (:saper)]

Attachment: Patch for trunk

More info: https://bugzilla.mozilla.org/show_bug.cgi?id=577847#c14

Comment 5

[Frédéric Buclin]

Comment on attachment 605381 [details] [diff] [review]
Patch for trunk

This is a good candidate for the MoreBugUrl extension, see comment 1. Also next time, do not forget to request review from timello, to put your patch in his radar.

Comment 6

[Matt Selsky [:selsky]]

Attachment: Add support for bugs.php.net, v2

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 616137 [details] [diff] [review]
Add support for bugs.php.net, v2

r=gerv.

Gerv

Comment 8

[Frédéric Buclin]

Comment on attachment 616137 [details] [diff] [review]
Add support for bugs.php.net, v2

>=== modified file 'extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl'

>+<li>A bug on bugs.php.net.</li>

Doesn't pass tests. Bareword "A bug" should either be "[% terms.Abug %] or renamed to something else. Please update your patch.

Comment 9

[Matt Selsky [:selsky]]

Attachment: Add support for bugs.php.net, v3

Renamed "A bug" as requested.

Comment 10

[Gervase Markham [:gerv]]

Comment on attachment 621490 [details] [diff] [review]
Add support for bugs.php.net, v3

r=gerv.

Gerv

Comment 11

[Frédéric Buclin]

Comment on attachment 621490 [details] [diff] [review]
Add support for bugs.php.net, v3

>=== modified file 'extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl'

>+<li>A b[% %]ug on bugs.php.net.</li>

bugs.php.net must also be written as b[% %]ugs.php.net, else t/009bugwords.t will catch it.

Comment 12

[Matt Selsky [:selsky]]

Attachment: Add support for bugs.php.net, v4

Update for bitrot from bug 571740.  Also fixes test breakage from the php website url.

Comment 13

[Gervase Markham [:gerv]]

Comment on attachment 626558 [details] [diff] [review]
Add support for bugs.php.net, v4

r=gerv.

Gerv

Comment 14

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/MoreBugUrl/Extension.pm
added extensions/MoreBugUrl/lib/PHP.pm
modified extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
Committed revision 8241.

Comment 15

[Frédéric Buclin]

Added to relnotes for 4.4.