Closed
Bug 735233
Opened 12 years ago
Closed 12 years ago
Shift-F6 should focus the location bar rather than the first focusable chrome element
Categories
(Firefox :: Keyboard Navigation, defect)
Firefox
Keyboard Navigation
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: alex_mayorga, Assigned: dao)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
Wit bug 249735 fixed, F6 now cycles through URL bar and content but no longer stops at the current tab on the tab bar. Holding Ctrl or Shift while pressing F6 cycles through content and the current tab on the tab bar but never stops at the URL bar. IMHO this is a small regression on keyboard navigation. I'd suggest the behavior to be like: - pressing F6 once focus URL bar, - pressing F6 twice focus web content, - pressing F6 a third time focus on the current tab on the tab bar Holding Ctrl or Shift while pressing F6 should cycle in reverse order, but the order should be consistent. Filing per Dão's request on bug 249735 comment #93
Assignee | ||
Comment 1•12 years ago
|
||
(In reply to alex_mayorga from comment #0) > I'd suggest the behavior to be like: [...] > - pressing F6 a third time focus on the current tab on the tab bar This doesn't make sense...
Summary: Pressing F6 repeatedly behaves erratically → Shift-F6 should focus the location bar rather than the first focusable chrome element
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dao
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #605520 -
Flags: review?(enndeakin)
Comment 3•12 years ago
|
||
Comment on attachment 605520 [details] [diff] [review] patch It might make sense to rename the command as now it doesn't always go to the next frame, but I'm not concerned either way.
Attachment #605520 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Neil Deakin from comment #3) > Comment on attachment 605520 [details] [diff] [review] > patch > > It might make sense to rename the command as now it doesn't always go to the > next frame, but I'm not concerned either way. Yeah, it's not ideal, but for lack of a better name I'd just keep it. "Next" is ambiguous enough that it's not exactly wrong... it's just the next frame in the opposite direction.
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/20cc9a2c361f
Target Milestone: --- → Firefox 14
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20cc9a2c361f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•