735339 - The 'Get mail' drop down shouldn't list IM accounts

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

... as it's not possible to get new emails from an IM account.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

This patch will disable the "Get mail" menu/button/command if there's only IM accounts, in addition to hiding the IM accounts from the "Get Mail" popup menu, the "File -> Get New Messages for" menu and the "Go -> Folder" menu.

Comment 2

[David :Bienvenu]

My chat accounts aren't showing up in go folders, or the get new mail dropdown, even w/o this patch. Why would that be? Or why would they show up for other people? Did the account stuff change since I created them in this profile?

Comment 3

[Florian Quèze [:florian]]

(In reply to David :Bienvenu from comment #2)
> My chat accounts aren't showing up in go folders, or the get new mail
> dropdown, even w/o this patch. Why would that be?

Maybe you are seeing bug 736035? If so, if you have any idea of the steps to reproduce, please comment in that bug.

Comment 4

[David :Bienvenu]

Comment on attachment 605791 [details] [diff] [review]
Patch

can you use let instead of var for the new function IsGetNewMessagesEnabled()?

Comment 5

[Florian Quèze [:florian]]

http://hg.mozilla.org/comm-central/rev/f4b337e10b51

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 605791 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: quite visible brokenness in the mail UI if IM accounts exist.

Comment 7

[Florian Quèze [:florian]]

http://hg.mozilla.org/releases/comm-aurora/rev/a32b1a8e83a1