735531 - Create a modal for entering a JSON object that is merged with the auto-generated package.json

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, enhancement, P1)

Description

[Daniel Buchner [:dbuc]]

We need a modal UI that allows developers to input a custom JSON object that is merged into the auto-generated package.json at during the package create cycle. This will allow for developers to add icons, preferences, and localization to their add-ons.

The UI should consist of an ACE editor and a save button. Before save, we will ensure that the text the user is saving actually generates an object. Once saved, this JSON object will have the auto-generated JSON object that makes up the package.json merged *into* it. We want to merge into it to ensure that any critical, auto-generated values are not overwritten by the user in their custom object.

Comment 1

[Sean McArthur [:seanmonstar]]

I'm considering adding an extra text field (turned into an ACE) on the current Properties modal, since well, it's extra properties.

Comment 2

[Daniel Buchner [:dbuc]]

Sounds good to me, just make sure to validate the text from that ACE editor area before posting that form ;)

Comment 3

[Daniel Buchner [:dbuc]]

Here is some CSS mods to make the editor area in the modal look better: 

#extra_json_ace {
	margin-right: -2px;
	border: 1px solid #aaa;
}

#extra_json_ace div.ace_scroller {
	border: none;
	border-radius: 0;
	box-shadow: 1px 1px 2px -2px #000; 
}

#extra_json_ace div.ace_sb {
	border-top: none;
	border-left: 1px solid #bbb;
}

Comment 4

[Sean McArthur [:seanmonstar]]

Doneskis.