735576 - [ruleview] The warning icon should disappear as soon as the value is correct

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Paul Rouget [:paul]]

Right now, you have to hit enter to know if the value is correct or not.

Comment 1

[Paul Rouget [:paul]]

triage, filter on centaur

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

This was held up due to a hard to find leak (fixed by somebody else).

This fix almost seems too easy :o/

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 613556 [details] [diff] [review]
Patch

Review of attachment 613556 [details] [diff] [review]:
-----------------------------------------------------------------

This causes spew to the error console while typing - a warning for every keystroke that doesn't parse.

We should be able to prevent this spew by wrapping the setProperty() with something like:

let prefVal = getPref("layout.css.report_errors");
setPref("layout.css.report_errors", false);
try {
  setProperty()
} finally {
  setPref("layout.css.report_errors, prefVal");
}

but it would be worth asking the layout guys if there's a better solution.

If we fix that it might be worth updating the live stylesheet as you type so that you don't need to press enter every time you want to try a value...

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Dave Camp (:dcamp) from comment #3)
> Comment on attachment 613556 [details] [diff] [review]
> Patch
> 
> Review of attachment 613556 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This causes spew to the error console while typing - a warning for every
> keystroke that doesn't parse.
> 
> We should be able to prevent this spew by wrapping the setProperty() with
> something like:
> 
> let prefVal = getPref("layout.css.report_errors");
> setPref("layout.css.report_errors", false);
> try {
>   setProperty()
> } finally {
>   setPref("layout.css.report_errors, prefVal");
> }
> 

That makes sense, we can do that.

> but it would be worth asking the layout guys if there's a better solution.
> 

It would be cool if we could get a list of possible property values to compare against. This list could also be used for autocomplete, I will post on dev.tech.layout.

> If we fix that it might be worth updating the live stylesheet as you type so
> that you don't need to press enter every time you want to try a value...

The problem with this is that when the value is invalid the property ceases to exist in the stylesheet but we should be able to do this.

Comment 5

[Dave Camp (:dcamp)]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> (In reply to Dave Camp (:dcamp) from comment #3)
> It would be cool if we could get a list of possible property values to
> compare against. This list could also be used for autocomplete, I will post
> on dev.tech.layout.

For autocomplete that might be useful, but we should let the css parser validate css.

> > If we fix that it might be worth updating the live stylesheet as you type so
> > that you don't need to press enter every time you want to try a value...
> 
> The problem with this is that when the value is invalid the property ceases
> to exist in the stylesheet but we should be able to do this.

We could do a validation and apply when valid.  This can be a separate bug.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Now with live values

Now we toggle the property and update the property live.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Removed live update

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: 5 month review ping plus rebase

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/254ec57084a6

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/254ec57084a6