735589 - B2G SMS: ctypes undefined error in systemlib.js in xpcshell tests for SMS

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Attachement 604277 in bug 734299 breaks xpcshell tests with error "resource://gre/modules/systemlibs.js:101: ReferenceError: ctypes is not defined". In systemlibs.js line 20, the already existing libcutils returns a dummy on error catched, while libnetutils still try to create an working object for return at line 100.

This error is found within x86_x64 b2g build.

Comment 1

[Philipp von Weitershausen [:philikon]]

The xpcshell test can easily import resource://gre/modules/ctypes.jsm and pass that into the worker scope.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: import ctyps.jsm

verified with existing test scripts

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 605819 [details] [diff] [review]
import ctyps.jsm

Hmm, does this even work? The worker only sees 'worker_ns' created in 'newWorker()', no? I was thinking of importing it directly into the worker namespace, like so:

  function newWorker(custom_ns) {
    let worker_ns = {
      ...
    };
    Cu.import("resource://gre/modules/ctypes.jsm", worker_ns);
    ...
    return worker_ns;
  }

I think that's more elegant, too...

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Comment on attachment 605819 [details] [diff] [review]
> import ctyps.jsm
> 
> Hmm, does this even work? The worker only sees 'worker_ns' created in
> 'newWorker()', no?

Strange, but it does :)

> I was thinking of importing it directly into the worker
> namespace, like so:
> 
>   function newWorker(custom_ns) {
>     let worker_ns = {
>       ...
>     };
>     Cu.import("resource://gre/modules/ctypes.jsm", worker_ns);
>     ...
>     return worker_ns;
>   }
> 
> I think that's more elegant, too...

Perfect!

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: import ctyps.jsm : V2

Comment 6

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/29e6ffe61193