735744 - add expand all button to runtests page

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: MozTrap, enhancement)

Description

[Cameron Dawson [:camd]]

In contrast to the management pages, the runtest page doesn't use AJAX.  Apparently this would be mostly JavaScript.

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/26443149

Comment 2

[Cameron Dawson [:camd]]

Eric Meyer changed story state to started in Pivotal Tracker

Comment 3

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
Jonny, besides opening all the list details, we need an "open" class added to the link itself. (this is all on the bulk-open branch)

Comment 4

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Eric: The basic JS is in place. Two remaining UI questions:

1) What would you like to happen in mixed cases (where some of the tests are expanded, and others are closed)?
2) If you manually expand or collapse all tests (without using bulk-open), should bulk-open magically correspond (i.e. add/removeClass 'open')?

Comment 5

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
1) I think all mixed cases should be considered "closed" - so clicking opens all. 
2) how hard would it be to respond to manual controls? the only case in which it is considered "open" is when all items are open.

Comment 6

[Cameron Dawson [:camd]]

Jonny Gerig Meyer changed story state to delivered in Pivotal Tracker

Comment 7

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
I think the expand all button needs a tooltip.  I fear it may not be obvious to people / they may not notice it.  But we can see how that goes.  Is this a standard place to put an expand all button?

Comment 8

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to rejected in Pivotal Tracker

Comment 9

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
Is this merged to master? Stories shouldn't be delivered until they're merged, and once they are merged we should remove the branch: tag.

Comment 10

[Cameron Dawson [:camd]]

Carl Meyer changed story state to started in Pivotal Tracker

Comment 11

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
I merged it before delivering, but didn't think to remove the PT tag. Fixed.

Comment 12

[Cameron Dawson [:camd]]

Eric Meyer added a comment in Pivotal Tracker:   
   
I added a tooltip. I also changed the icons to make them more unique, and hopefully more descriptive and noticeable.

Comment 13

[Cameron Dawson [:camd]]

Eric Meyer changed story state to delivered in Pivotal Tracker

Comment 14

[Cameron Dawson [:camd]]

Eric Meyer changed story state to delivered in Pivotal Tracker

Comment 15

[Cameron Dawson [:camd]]

Cameron Dawson added a comment in Pivotal Tracker:   
   
awesome!  this looks great.  I really like the new icons, too.  More robust and easier to notice, I think.

Comment 16

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker

Comment 17

[Matt Brandt [:mbrandt]]

Bumping to verified as per comment 15, shipped.