735987 - [New Tab Page] Dropping blocked links onto the grid again should unblock them

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Girish Sharma [:Optimizer]]

When you add a site manually to the New Tab Page, you cannot remove it by clicking on the cross button on upper right corner unless you unpin it.
And if you unpin it after clicking on the cross atleast once, then it automatically gets removed on unpinning.

Comment 1

[Girish Sharma [:Optimizer]]

PS: This behavior is visible only after the New layout for NTP landed.

Comment 2

[Siddhartha Dugar [:sdrocking]]

This happens randomly.

Comment 3

[Girish Sharma [:Optimizer]]

The STR are very complex for this bug, 
1) All the other tabs should be pinned (either manually added or pinning the already existing thumbnails)
2) This only happens to the thumbnails added manually
3) This does not start happening untill all the tiles are filled and pinned.
4) But once the above condition is satisfied, this will happen untill you close the page, even if you remove the already existing sites.

Still there might be some other STR also. This is random at times.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Unblocks a link before pinning it on the grid when accepting an external drop.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/34a7a331811f

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/34a7a331811f

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 606141 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): new newtab layout
User impact if declined: weird behavior, removing a site not working
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): small patch with test
String changes made by this patch: none

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 606141 [details] [diff] [review]
patch v1

[Triage Comment]
Low risk patch in support of correctness in a new feature. Approved for Aurora 13.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4b7327c0fd00

Comment 10

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120424 Firefox/13.0a2

Verified on Mac OS 10.6, Ubuntu 11.10 and Windows 7.

1. Manually add a site to the new tab page.
2. Close the new tab page.
3. Open the new tab page.
4. remove the site added in step 1. 

The site can now be removed.

Comment 11

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca13a15a1e54

Comment 12

[Neil Deakin]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5e1ba6d6ab9