Closed
Bug 736058
Opened 12 years ago
Closed 12 years ago
ringmark's Web Storage test fails
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: alex_mayorga, Assigned: smaug)
References
Details
(Keywords: regression, Whiteboard: [qa+])
Attachments
(2 files, 1 obsolete file)
2.98 KB,
patch
|
sicking
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.97 KB,
patch
|
Details | Diff | Splinter Review |
Web Storage test at http://rng.io/ is failing. Initially reported at http://forums.mozillazine.org/viewtopic.php?p=11821601#p11821601 Previously it was fine. Regression window: Stop Ring 1 Complete (301 tests): http://hg.mozilla.org/mozilla-central/rev/75b24396b0ce Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120308 Firefox/13.0a1 ID:20120308063137 Stop Testing: Web Storage...: Error: Permission denied for <http://rng.io> to create wrapper for object of class UnnamedClass Source file: http://rng.io/dist/ringmark.min.js Line: 3 http://hg.mozilla.org/mozilla-central/rev/08809a43e082 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120308 Firefox/13.0a1 ID:20120308133632 Puslog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=75b24396b0ce&tochange=08809a43e082 Triggered by: 08809a43e082 Olli Pettay — Bug 730891, event ctor for StorageEvent, r=sicking,kyle
Assignee | ||
Comment 1•12 years ago
|
||
Looks like the test wants to create an event in an old way, yet it tests the typeof window.StorageEvent.
Assignee | ||
Comment 2•12 years ago
|
||
(I'll add some test too)
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → bugs
Attachment #606202 -
Attachment is obsolete: true
Attachment #606204 -
Flags: review?(jonas)
Updated•12 years ago
|
Component: Untriaged → DOM: Events
Product: Firefox → Core
QA Contact: untriaged → events
Comment on attachment 606204 [details] [diff] [review] patch Review of attachment 606204 [details] [diff] [review]: ----------------------------------------------------------------- I'd really prefer to get the spec changed to not require this behavior. .createEvent is a very silly API. r=me if you really prefer to do this though.
Attachment #606204 -
Flags: review?(jonas) → review+
Reporter | ||
Comment 5•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1) > Looks like the test wants to create an event in an old way, yet it > tests the typeof window.StorageEvent. If this is bad for the web at large, maybe is worth trying to contact the creators of the test to fix it. No many contact details at http://rng.io/about/ though...
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 606204 [details] [diff] [review] patch I think we should land the patch, and if spec changes, remove support for createEvent. also, we should land this to Aurora too. I don't want to break pages too often.
Attachment #606204 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/58a2cd0203ee
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Keywords: regression
OS: Windows 7 → All
Hardware: x86 → All
Target Milestone: --- → mozilla14
Version: unspecified → Trunk
Comment 8•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #6) > Comment on attachment 606204 [details] [diff] [review] > patch > > I think we should land the patch, and if spec changes, remove support > for createEvent. > also, we should land this to Aurora too. I don't want to break pages too > often. Would you mind addressing the risk for this nomination?
tracking-firefox13:
--- → +
Assignee | ||
Comment 9•12 years ago
|
||
Very low risk. We just enable creating storage events using document.createEvent()
Comment 10•12 years ago
|
||
Comment on attachment 606204 [details] [diff] [review] patch [Triage Comment] Given the low risk evaluation, approved for Aurora 12.
Attachment #606204 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 11•12 years ago
|
||
Commit message: Bug 736058, support createEvent('StorageEvent'), r=sicking
Keywords: checkin-needed
Assignee | ||
Comment 12•12 years ago
|
||
So, checkin-needed for aurora.
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 13•12 years ago
|
||
Assignee | ||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f9f77313b59e
status-firefox13:
--- → fixed
Comment 15•12 years ago
|
||
Verified on Firefox 13 beta 3 that the test from: http://rng.io/ passes and that no error like the one from the Description is thrown. Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6: Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0 Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0
You need to log in
before you can comment on or make changes to this bug.
Description
•