Closed Bug 736087 Opened 12 years ago Closed 12 years ago

Wifi: Rename the DOM service to not have the ns prefix

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(2 files)

For the DOM service
6.73 KB, patch
philikon
: review+
Details | Diff | Splinter Review
For the chrome side
7.51 KB, patch
philikon
: review+
Details | Diff | Splinter Review 

        Attachment #606632 -
        Flags: review?(philipp)

    
    

    
  


  

        Attachment #606633 -
        Flags: review?(philipp)

        Attachment #606633 -
        Flags: review?(philipp) → review+

    
    

    
  
Comment on attachment 606633 [details] [diff] [review]
For the chrome side

So one thing that occurred to me as well: WifiWorker and its companions should probably live in dom/system/gonk. But we can do that in a separate bug, and perhaps even while or after we consolidate some of the code in the network manager.

        Attachment #606632 -
        Flags: review?(philipp) → review+

    
    

    
  
Comment on attachment 606632 [details] [diff] [review]
For the DOM service

Also, as per dev-webapi discussions: the "manager" part of the DOM API is pretty useless. navigator.wifi is much nicer (because shorter) than navigator.wifiManager (modulo moz prefix). But that, too, can be a follow-up bug.

    
    

    
  
Yeah, I filed that as bug 736088.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: