736113 - Can't get camera stream when camera app served from subdomain

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ben Francis [:benfrancis]]

I set up my desktop PC to serve each Gaia app from its own subdomain and then set homescreen.gaiamobile.org as the homescreen on the device so it fetches apps over Wifi.

When the camera app is served from camera.gaiamobile.org and I start the app from homescreen.gaiamobile.org it fails to get a video stream and I see the following output in logcat:

E/GeckoConsole( 3122): [JavaScript Error: "uncaught exception: [Exception... "'[JavaScript Error: "from is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/CameraContent.js" line: 65}]' when calling method: [nsIDOMGlobalPropertyInitializer::init]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: http://camera.gaiamobile.org/js/camera.js :: camera_setSource :: line 60"  data: yes]"]
E/GeckoConsole( 3122): [JavaScript Warning: "Invalid URI. Load of media resource  failed." {file: "http://camera.gaiamobile.org/camera.html" line: 0}]
E/GeckoConsole( 3122): [JavaScript Error: "label is null" {file: "chrome://global/content/bindings/videocontrols.xml" line: 684}]

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

> When the camera app is served from camera.gaiamobile.org and I start the app from homescreen.gaiamobile.org it fails to get a video stream and I see the following output in logcat:

Just to be clear, you mean the homescreen is served from homescreen.gaiamobile.org?

Comment 2

[Ben Francis [:benfrancis]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> > When the camera app is served from camera.gaiamobile.org and I start the app from homescreen.gaiamobile.org it fails to get a video stream and I see the following output in logcat:
> 
> Just to be clear, you mean the homescreen is served from
> homescreen.gaiamobile.org?

Yes that's correct. The homescreen is served from homescreen.gaiamobile.org and the camera is served from camera.gaiamobile.org

Fabrice has looked into this and it turns out that we need to add permission for the subdomain using the permissions manager in shell.js, I was only aware of the whitelist prefs. He said there was also another minor thing that needed fixing to close this bug.

We're currently using two different mechanisms for giving permissions - prefs and the existing permissions DB, Fabrice thinks we should use the permissions DB for everything.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: patch

This patch just fixes the error that Ben saw. I'd prefer to have a follow-up dealing with a sane way to set up permissions for default apps in their subdomains.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 606410 [details] [diff] [review]
patch

>diff --git a/b2g/components/CameraContent.js b/b2g/components/CameraContent.js
>@@ -62,7 +62,7 @@ CameraContent.prototype = {
>     let perm = principal == secMan.getSystemPrincipal() ? Ci.nsIPermissionManager.ALLOW_ACTION : Services.perms.testExactPermission(principal.URI, "content-camera");
> 
>     //only pages with perm set and chrome pages can use the camera in content
>-    this.hasPrivileges = perm == Ci.nsIPermissionManager.ALLOW_ACTION || from.schemeIs("chrome");
>+    this.hasPrivileges = perm == Ci.nsIPermissionManager.ALLOW_ACTION;

uh. I guess this is because |from| is undefined.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7eb2c85266

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b7eb2c85266