736114 - B2G Wifi: Fire notification for signal strength changes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

We need this to put the relative signal strength in the title bar.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v.5

Still to do here:

- Add an API so that you don't have to wait for an event to update the status (mozWifiManager.connectionInfo, perhaps?).
- Suppress the event if nothing changed.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v1

There is now a .connectionInformation property as well as the event. I also avoid sending the event if the signal strength hasn't changed more than 10% since the last time we checked.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Oh, please pretend that this was applied in the previous diff:

diff --git a/dom/wifi/nsIWifi.idl b/dom/wifi/nsIWifi.idl
index 8063aac..f06565d 100644
--- a/dom/wifi/nsIWifi.idl
+++ b/dom/wifi/nsIWifi.idl
@@ -43,7 +43,7 @@
 interface nsIWifi : nsISupports {
 };
 
-[scriptable, uuid(1509221f-470e-4445-b476-88e74fd5c617)]
+[scriptable, uuid(bdc74103-85e7-4e6a-bf68-55fc35b7ad2f)]
 interface nsIDOMWifiManager : nsISupports {
     /**
      * TODO Remove in favor of a settings API.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 607150 [details] [diff] [review]
Patch v1

If this is needed for 2.5, it needs review. Chris might have a little more time at this point than gal.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Rebased

This is rebased and fixes a couple of dumb bugs in DOMWifiManager.js (notably where I'd switched from this._onConnection... to this._connection...).

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

(slightly tweaked to fix even more typos) https://hg.mozilla.org/mozilla-central/rev/7f4d6e62d1f7