736608 - On some linux systems webrtc fails to link due to not finding XML_* functions from expat

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

This is references from libjingle, which uses 'normal' expat (char, not PR_UniChar).
Fails on builders and on Ethan's Ubuntu 11.10, not on Fedora 15x64

Probably a side-effect of the SipCC checkin or maybe Bas's

libjingle tries to use system expat on linux, but instead ends up looking for an internal link symbol.  May be an include-path issue at the heart.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: hack to paper over the external expat problem by building it internal

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 606739 [details] [diff] [review]
hack to paper over the external expat problem by building it internal

Note: this patch is not for eventual checkin to mozilla-central; the include issue that causes the base problem should be solved, and this bug kept open until then

Comment 3

[Ethan Hugg [:ehugg]]

Comment on attachment 606739 [details] [diff] [review]
hack to paper over the external expat problem by building it internal

Review of attachment 606739 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the problem where it breaks on Ubuntu64 but succeeds on Fedora15.  Building expat internally reduces risk of build platform variability.  The only downside I see is a marginally longer build time.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

hack checked in as https://hg.mozilla.org/projects/alder/rev/10a5f0e2bc71

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Temp hack - Use system expat on Mac but not linux

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment 606831 [details] [diff] - Partial backout of previous patch - re-enable system expat on Mac

https://hg.mozilla.org/projects/alder/rev/41d5c11a453f

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Temp hack (fixed) - Use system expat on Mac but not linux

Comment 8

[Eric Rescorla (:ekr)]

Attachment: Fix for this linkage problem

We really don't want to use the system lib on Mac, but we get collisions with the existing expat. The following patch munges the unmunged symbols on the existing expat so that doesn't happen and then uses the libjingle/third_party expat.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 616262 [details] [diff] [review]
Fix for this linkage problem

f+ with mods to fold expat back into the main list of libs (and remove the now-spurious comment)

Comment 10

[Eric Rescorla (:ekr)]

Checked in with nits as: http://hg.mozilla.org/projects/alder/rev/70cddbbd129b