Closed
Bug 736689
Opened 12 years ago
Closed 12 years ago
Disable tearing on OS X
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
921 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We tear much worse than all other browser on OS X. This patch fixes it. I'm told this change was originally done for performance, but it doesn't seem to make much difference anymore: http://tinyurl.com/7ay3jzo. I expect because we no longer paint very much to the window context, we no longer see the improvement this used to bring.
Attachment #606826 -
Flags: review?(roc)
Comment on attachment 606826 [details] [diff] [review] Disable tearing Review of attachment 606826 [details] [diff] [review]: ----------------------------------------------------------------- I expect that the "all painting should go through the refresh driver" patches have helped make this unnecessary. Please watch out for reports of Mac performance regressions though.
Attachment #606826 -
Flags: review?(roc) → review+
Updated•12 years ago
|
Attachment #606826 -
Flags: approval-mozilla-central+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/47da536b5144
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla14
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47da536b5144
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
For the record: Improvement! DHTML 2 MozAfterPaint decrease 6.66% on MacOSX 10.6 (rev4) Mozilla-Inbound --------------------------------------------------------------------------------------- Previous: avg 345.945 stddev 1.930 of 30 runs up to revision bce6cabacc88 New : avg 322.888 stddev 1.167 of 5 runs since revision 47da536b5144 Change : -23.057 (6.66% / z=11.945) Graph : http://mzl.la/J7DcHN Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bce6cabacc88&tochange=47da536b5144 Changesets: * http://hg.mozilla.org/integration/mozilla-inbound/rev/47da536b5144 : Jeff Muizelaar <jmuizelaar@mozilla.com> - Bug 736689. Disable tearing on OS X. r=roc, a=joe We tear much worse than all other browser on OS X. I'm told this change was originally done for performance, but it doesn't seem to make much difference anymore: http://tinyurl.com/7ay3jzo. I expect because we no longer paint very much to the window context, we no longer see the improvement this used to bring. In addition, the refresh driver already coalesces paints. : http://bugzilla.mozilla.org/show_bug.cgi?id=736689 Bugs: * http://bugzilla.mozilla.org/show_bug.cgi?id=736689
Comment 5•12 years ago
|
||
That astonishes me!
Assignee | ||
Comment 6•12 years ago
|
||
FWIW, we still tear :(
You need to log in
before you can comment on or make changes to this bug.
Description
•