736707 - B2G SMS: Support type-0 message

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

According to 3GPP 23.040 section 9.2.3.9, "A short message type 0 indicates that the ME must acknowledge receipt of the short message but shall discard its contents."

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

There are also three levels of "don't store" throughout the spec and might have to be taken into consideration together. They are:

1) TP-PID: the whole message should be discarded without further handling.
2) DCS MWI(Message Waiting Indication): message should be read and discard after notifying the indication and/or displaying the message content. See bug 736710.
3) In user data header Enhanced Voice Mail Information. See bug 736710.

We should focus on 1) in this issue and provide a way that can be reused in related tasks.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Support Type-0 Message

This change is based on bug 736697, Part 2: Refactor to share methods.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

verified with rev 9ff494dfc9b0 ;)

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Support Type-0 Message : V2

1) rebase due to changes in attachment #609252 [details] [diff] [review]
2) now based on bug 736697 part 5

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 1: TP-PID sanity checks

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 2: Support Type-0 Message : V3

rebase due to changes in attachment 609634 [details] [diff] [review] in bug 736697

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 1: TP-PID sanity checks : V2

accommodate to changes made in bug 736697 attachment 610085 [details] [diff] [review]

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 1: TP-PID sanity checks : V3

upate comments

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 2: Support Type-0 Message : V4

update comments

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 1: TP-PID sanity checks : V4

missing comma

Comment 11

[Philipp von Weitershausen [:philikon]]

Comment on attachment 610477 [details] [diff] [review]
Part 1: TP-PID sanity checks : V4

Review of attachment 610477 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3035,5 @@
> +   *
> +   * @return read pid and effective pid.
> +   *
> +   * @see 3GPP TS 23.040 9.2.3.9
> +   */

Instead of an array return value, could this method simply take the msg object and set msg.epid, msg.pid? I think I would prefer that.

r=me with that, unless there's a good reason not do this.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 1: TP-PID sanity checks : V5

review comment 11

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Part 2: Support Type-0 Message : V5

review comment 11

Comment 14

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Philipp von Weitershausen [:philikon] from comment #11)
> Instead of an array return value, could this method simply take the msg
> object and set msg.epid, msg.pid? I think I would prefer that.
> 
> r=me with that, unless there's a good reason not do this.

I agree. That simplifies the patches. Thanks.

Comment 15

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4f1f7d050a
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dffa132f245

Comment 16

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0d4f1f7d050a
https://hg.mozilla.org/mozilla-central/rev/6dffa132f245