736735 - notification.css: Use inheritance instead of non-performant css.

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Philip Chee]

There are several bugs that could be more easily fixed if we were a bit more clever in our XBL e.g.
Bug 415400 - notification bar icons aren't accessible through CSS
Bug 694786 - Remove hard coded dependency on xpinstallItemGeneric.png from notification.xml.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 use inheritance.

This would be super useful in SeaMonkey because then we can remove hard coded image chrome paths and do things like:

.messageImage[type][value="plugin-crashed"] {
  list-style-image: url("chrome://mozapps/skin/plugins/notifyPluginCrashed.png");
}

.messageImage[type][value="addon-install-complete"] {
  list-style-image: url("chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png");
}

Comment 2

[Philip Chee]

Pushed to inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/20031e64e0f3

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/20031e64e0f3

Comment 4

[Ed Hume]

Thanks for thinking of me. I can't really comment on the javascript, but the css looks much better. It looks skinnable.