736739 - --disable-installer packaging failures: missing or unnecessary file: bin/uninstall/helper.exe, bin/maintenanceservice_installer.exe

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: mozconfig

I normally build with official branding enabled. Since bug 713132 landed, packaging as failed with 

Error: package error or possible missing or unnecessary file: bin/uninstall/helper.exe (package-manifest, 31).
Error: package error or possible missing or unnecessary file: bin/maintenanceservice_installer.exe (package-manifest, 415).
Error: found error(s) while packaging, see above for details.
make[2]: *** [stage-package] Error 9

This bug prevents the crash automation from performing tests on Nightly builds on Windows.

Comment 1

[Bob Clary [:bc] (inactive)]

I've added a patch to my local build environments to back the patch out and and am no longer blocked by this, but it will affect any attempt to perform official builds as is.

Comment 2

[Serge Gautherie (:sgautherie)]

Given bug 650322, could you explain why --disable-installer would be needed in your case(s)?

Comment 3

[Bob Clary [:bc] (inactive)]

It isn't absolutely needed but I don't use the installer and disabled it long ago to save time. If we are going to remove the option, I can go ahead and build it unless there is another way to disable it.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Bob Clary [:bc:] from comment #3)

> It isn't absolutely needed but I don't use the installer and disabled it

I know the story: that's exactly why I filed bug 604266 initially :-|

> long ago to save time. If we are going to remove the option, I can go ahead
> and build it unless there is another way to disable it.

There isn't: the (stalled) plan is to remove MOZ_INSTALLER too in the end.

Comment 5

[(not currently active) Ted Mielczarek]

All things being equal, we prefer to have fewer configure options. All the prereqs for building the installer ship with MozillaBuild now, which is the only supported build environment on Windows, so it's not an onerous requirement.