736845 - Remove useless "container" div from about:home

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/70cdb996d790

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think once it is merged, may be worth to have this in Aurora, since snippets are going to be rewritten better to give them stable document contents (yes, wouldn't be hard to workaround this, but no reason to not avoid that).

Comment 3

[Dão Gottwald [:dao]]

> snippets are going to be rewritten better to give them stable document
> contents

What exactly does this mean with regards to this bug?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

snippets can modify css, for example when they changed the background to black for a day in the past. They may try to do that on "container" and get different results across versions.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I actually forgot a comma in that phrase, "snippets are going to be rewritten, so better give them"

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/70cdb996d790

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 606971 [details] [diff] [review]
patch

[Triage Comment]
Low risk patch in support of correctness in a new feature. Approved for Aurora 13.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/0cf845b2ede5