Closed
Bug 736860
Opened 12 years ago
Closed 12 years ago
filter editor dialog uses different minus signs on buttons to remove filter rules and filter actions
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
(Keywords: polish, ux-consistency)
Attachments
(1 file)
1.41 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
Unify the character used for minus signs on buttons to remove filter rules and filter actions in the Filter editor. I suggest to use \u2212 character as that one is rendered longer and in line with the plus sign. It is already used on the remove filter rule button.
Attachment #606984 -
Flags: ui-review?(bwinton)
Attachment #606984 -
Flags: review?(bwinton)
I just noticed those buttons (for actions) do not have a tooltip text. The same buttons in terms definition above do have tooltips. What about throwing that in too?
Comment 3•12 years ago
|
||
(In reply to :aceman from comment #2) > I just noticed those buttons (for actions) do not have a tooltip text. The > same buttons in terms definition above do have tooltips. > What about throwing that in too? Yes and are they accessible ?
Comment 5•12 years ago
|
||
Comment on attachment 606984 [details] [diff] [review] patch Looks better, and the code seems fine. I'ld like it to be accessible, but if you want to do that in a separate bug that's okay. r=me, ui-r=me. Thanks, Blake.
Attachment #606984 -
Flags: ui-review?(bwinton)
Attachment #606984 -
Flags: ui-review+
Attachment #606984 -
Flags: review?(bwinton)
Attachment #606984 -
Flags: review+
OK, I'll look at that in a new bug. Reviews are not that abundant to throw them away once granted:)
Keywords: checkin-needed
Comment 7•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/7cdd63e88115
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•