736887 - nsHttpChannel.cpp: warning C4244: 'argument' : conversion from 'double' to 'PRTime', possible loss of data

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #576006 +++

MSVC2010 complains with the warning in the summary. The code is:

  #define IMPL_TIMING_ATTR(name)                               \
  NS_IMETHODIMP                                                \
  nsHttpChannel::Get##name##Time(PRTime* _retval) {            \
    mozilla::TimeStamp stamp;                                  \
    Get##name(&stamp);                                         \
    if (stamp.IsNull()) {                                      \
        *_retval = 0;                                          \
        return NS_OK;                                          \
    }                                                          \
    *_retval = mChannelCreationTime +                          \
        (stamp - mChannelCreationTimestamp).ToSeconds() * 1e6; \
    return NS_OK;                                              \
  }

AFAICT, the simplest way to avoid the warning is to explicitly cast the expression ((stamp - mChannelCreationTimestamp).ToSeconds() * 1e6) to PRTime.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Use explicit cast to avoid the warning

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/497086b1463c

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/497086b1463c