736895 - Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

I verified that HttpAsyncAborter's constructor does not dereference the passed-in pointer.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 607022 [details] [diff] [review]
Suppress warning warning C4355: 'this' : used in base member initializer list in nsHttpChannel::nsHttpChannel

Review of attachment 607022 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +69,5 @@
>  #include "mozilla/Telemetry.h"
>  #include "nsDOMError.h"
>  #include "nsAlgorithm.h"
>  #include "sampler.h"
> +#include "base/compiler_specific.h"

I'm a little leery about depending too much on the chromium IPC headers; it'd be better if something similar to ALLOW_THIS_IN_INITIALIZER_LIST was added to MFBT first.  There are certainly other places that could benefit from it.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6348b1ae1f85

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/6348b1ae1f85