736902 - Remove support for unused SetSwapRectangleANDROID symbol

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Michael Wu [:mwu]]

Attachment: Remove SetSwapRectangleANDROID

We never used this, and all this does is make egl libraries without it fail to load.

Comment 1

[Andreas Gal :gal]

Should we support it though? Not opposed to removing it for now but I would like to understand whether this was dropped in 4.0 or we just don't support it right.

Comment 2

[Michael Wu [:mwu]]

(In reply to Andreas Gal :gal from comment #1)
> Should we support it though? Not opposed to removing it for now but I would
> like to understand whether this was dropped in 4.0 or we just don't support
> it right.

The surfaceflinger code talks about how this is slow so we probably don't want support for it. https://github.com/cgjones/android-frameworks-base/blob/gingerbread-b2g/services/surfaceflinger/DisplayHardware/DisplayHardware.cpp#L241 Apparently using setUpdateRectangle looks the preferred solution, but I don't know how it improves things.

Comment 3

[Andreas Gal :gal]

Great. Land it! :)

Comment 4

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93ea6c992e17

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/93ea6c992e17

Comment 6

[Andreas Gal :gal]

++mounir