Closed
Bug 737080
Opened 12 years ago
Closed 12 years ago
Some Certificates Advanced Option windows are fixed to 600x400 in size.
Categories
(Thunderbird :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: etirta, Assigned: mkmelin)
Details
Attachments
(1 file)
3.37 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20100101 Firefox/10.0.2 Build ID: 20120215223356 Steps to reproduce: 1. Open 'Tools\Options'. 2. In 'Certificates' tab open either 'View Certificates', 'Revocation Lists', or 'Security Devices'. Actual results: Those Certificates Advanced Option windows are fixed in size to 600x400. This is due to in Thunderbird, the file 'omni.ja\chrome\messenger\content\messenger\preferences\advanced.js', the corresponding open function the initial window size are hard coded instead of using the corresponding persisted screenX & screenY data from localstore.rdf. Firefox does not hard code these, but Thunderbird does. -------- showCertificates: function () { document.documentElement.openWindow("mozilla:certmanager", "chrome://pippki/content/certManager.xul", "width=600,height=400", null); }, showCRLs: function () { document.documentElement.openWindow("mozilla:crlmanager", "chrome://pippki/content/crlManager.xul", "width=600,height=400", null); }, showOCSP: function () { document.documentElement.openSubDialog("chrome://mozapps/content/preferences/ocsp.xul", "", null); }, showSecurityDevices: function () { document.documentElement.openWindow("mozilla:devicemanager", "chrome://pippki/content/device_manager.xul", "width=600,height=400", null); } ------ Expected results: Functions showCertificates(), showCRLs(), and showSecurityDevices(), should not hard code the initial window size when they call openWindow().
Assignee | ||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Component: General → Preferences
Ever confirmed: true
OS: Windows XP → All
QA Contact: general → preferences
Hardware: x86 → All
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #609035 -
Flags: review?(mbanner)
Comment 2•12 years ago
|
||
Comment on attachment 609035 [details] [diff] [review] proposed fix Thanks Edoardo, Magnus, I'd been occasionally wondering why the show certificates dialog was the wrong size...
Attachment #609035 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/5bd67e621477 ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•