737122 - Attr nodes shouldn't have children

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

content/base/public/Makefile.in                   |    1 -
 content/base/public/nsIMutationObserver2.h        |   93 ------------------------------------------------------------
 content/base/src/nsDOMAttribute.cpp               |  170 ++++++++++---------------------------------------------------------------------------------------------------
 content/base/src/nsDOMAttribute.h                 |   23 ++------------
 content/base/src/nsNodeIterator.cpp               |    9 -----
 content/base/src/nsNodeIterator.h                 |    3 +-
 content/base/src/nsNodeUtils.cpp                  |   55 +----------------------------------
 content/base/src/nsNodeUtils.h                    |    7 ----
 content/base/src/nsStubMutationObserver.cpp       |    3 -
 content/base/src/nsStubMutationObserver.h         |    5 ---
 content/base/src/nsTextNode.cpp                   |   23 --------------
 content/base/src/nsTextNode.h                     |    7 ----
 content/base/test/Makefile.in                     |    5 ---
 content/base/test/test_bug590771.html             |   72 ----------------------------------------------
 content/base/test/test_bug598877.html             |   26 ----------------
 content/base/test/test_bug600466.html             |   28 ------------------
 content/base/test/test_bug600468.html             |   28 ------------------
 content/base/test/test_bug600471.html             |   29 ------------------
 dom/tests/mochitest/dom-level1-core/exclusions.js |    6 +++-
 19 files changed, 28 insertions(+), 565 deletions(-)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

RemoveChildAt shouldn't throw

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 608443 [details] [diff] [review]
Patch v1.1

Review of attachment 608443 [details] [diff] [review]:
-----------------------------------------------------------------

yay!

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/af7362ead6e5

Comment 4

[Mike Taylor [:miketaylr]]

It seems this change broke OSX Mavericks Server web calendar: See Bug 939619

Comment 5

[Sebastian Zartner [:sebo]]

I've finally marked the related attributes and methods as obsolete at https://developer.mozilla.org/en-US/docs/Web/API/Attr#Deprecated_properties_and_methods.

Please let me know whether I missed anything!

Sebastian