Closed
Bug 737221
Opened 12 years ago
Closed 12 years ago
GC: HeapId::pre barrier needs to check for strings
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
We should never hit the HeapId::pre barrier in normal engine usage. If we ever do start using this, the fact that strings are not caught here will be a bug.
|
Assignee | |
Comment 1•12 years ago
|
||
I'm not sure if the JS_UNLIKELYs make sense after this patch. I don't really know what the common case is here -- JSID_IS_VOID maybe? Perhaps, if we do know what to expect as a common case, it would be better to detect it and exit early with a single branch here?
Attachment #607733 -
Flags: review?(wmccloskey)
Attachment #607733 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/65e02a60d3dd
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65e02a60d3dd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•