73797 - Move CoCreateInstance out of the nsLocalFile.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

If the nsLocalFileWin has to resolve a symlink (shortcut), it will call
CoCreateInstance.  This call should be moved into startup code.

Comment 1

[Doug Turner (:dougt)]

Attachment: Move CoCreateInstance into nsLocalFile startup code.

Comment 2

[Doug Turner (:dougt)]

chris, can i get a r/sr on this simple patch.  It will only speed localfiles on
windows up when there is a FNF condition.

Comment 3

[Chris Waterson]

+#ifdef XP_WIN
+  CoInitialize(NULL);  // FIX: we should probably move somewhere higher up 
during startup
+#endif

Uh, that's what you did, right? Or do you still want to move it *earlier*?

+#ifdef DOUGT_debug
+    printf("localfile - resolving symlink\n");
+#endif
+

Do you want to check this in?

sr=waterson

Comment 4

[Doug Turner (:dougt)]

Yes, I still think that this should go higher.  Maybe the application should do 
this?  But for now, it is much better where it is.

Yes, I want the printf.  

thanks.

Comment 5

[Darin Fisher]

r=darin

Comment 6

[Doug Turner (:dougt)]

Thanks guys.  Fixed is in.