Closed
Bug 738052
Opened 12 years ago
Closed 12 years ago
Noise in the error console due to broken CSS when opening the preference window (in Test pilot)
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird12 fixed, thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: florian, Assigned: aceman)
Details
Attachments
(1 file, 1 obsolete file)
1.89 KB,
patch
|
aceman
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Warning: Expected declaration but found '/'. Skipped to next declaration. Source File: chrome://messenger/skin/preferences/preferences.css Line: 207 The offending code is: 204 #providerForm label{ 205 width: 75px; 206 text-align: right; 207 // padding-right: 3px; ??? 208 } Line 207 should be removed, and a space is missing before { on line 204. http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/preferences/preferences.css#161 http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preferences/preferences.css#204 http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/preferences/preferences.css#131
I fix the space in the next patch when bwinton decides whether it is better to remove the line 207 or just fix the comment delimiters as I have done in the patch.
Comment 3•12 years ago
|
||
Comment on attachment 608111 [details] [diff] [review] fix Stealing this review request.
Attachment #608111 -
Flags: review?(bwinton) → review?(mconley)
Comment 4•12 years ago
|
||
Comment on attachment 608111 [details] [diff] [review] fix Review of attachment 608111 [details] [diff] [review]: ----------------------------------------------------------------- aceman: Good catches, and an easy review. The stuff in themes/*/preferences.css should be excised, since bug 739279 will take care of it, and I don't really want it to get bitrotted. With the changes to the preferences.css files removed, this is r=me. ::: mail/themes/gnomestripe/mail/preferences/preferences.css @@ +130,5 @@ > > #providerForm label{ > width: 150px; > text-align: right; > +/* padding-right: 3px; ??? */ The patch for bug 739279 will take care of this. To prevent bitrotting it, let's omit the changes to themes/*/preferences.css for now.
Attachment #608111 -
Flags: review?(mconley) → review+
r=mconley.
Attachment #608111 -
Attachment is obsolete: true
Attachment #613710 -
Flags: review+
Updated•12 years ago
|
Keywords: checkin-needed
Considering the patch is now completely different to the original description, let's move it to the Test pilot component.
Component: Theme → Test Pilot
Product: Thunderbird → Mozilla Labs
QA Contact: theme → test-pilot
Summary: Noise in the error console due to broken CSS when opening the preference window → Noise in the error console due to broken CSS when opening the preference window (in Test pilot)
Comment 7•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/523577cb590f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Comment 8•12 years ago
|
||
(In reply to :aceman from comment #6) > Considering the patch is now completely different to the original > description, let's move it to the Test pilot component. Please don't at the moment. We're a separate branch to test pilot at the moment and so we're keeping bugs about Thunderbird's version in Thunderbird.
Component: Test Pilot → General
Product: Mozilla Labs → Thunderbird
QA Contact: test-pilot → general
Target Milestone: 1.3 → ---
Updated•12 years ago
|
Target Milestone: --- → Thunderbird 14.0
Comment 9•12 years ago
|
||
Comment on attachment 613710 [details] [diff] [review] fix v2 [Triage Comment] Taking forward to aurora/beta as this actually fixes an issue with notifications in test pilot being transparent. I also did a version bump for the in-tree test pilot here: http://hg.mozilla.org/comm-central/rev/a030c1d42585
Attachment #613710 -
Flags: approval-comm-beta+
Attachment #613710 -
Flags: approval-comm-aurora+
Comment 10•12 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/06383f9e9217 http://hg.mozilla.org/releases/comm-aurora/rev/d1a0eeb209fb http://hg.mozilla.org/releases/comm-beta/rev/7748e000cbeb http://hg.mozilla.org/releases/comm-beta/rev/7e631de9f7de
status-thunderbird12:
--- → fixed
status-thunderbird13:
--- → fixed
Assignee | ||
Comment 11•12 years ago
|
||
Is that issue filed/discussed anywhere?
You need to log in
before you can comment on or make changes to this bug.
Description
•